Conversation
1fe7468 to
44d0fe2
Compare
51d4c23 to
75a7d55
Compare
dahlia
left a comment
There was a problem hiding this comment.
By the way, if this patch requires a bleeding-edge version of Mypy, does it mean consumers who use both this package and Mypy also need to install the same (or higher) version of Mypy?
Yes. Because it requires bleeding-edge version of Mypy, it may be better to turn this pull request as draft until a new Mypy release introduced. |
|
The last release of Mypy (0.971 in 2022-07-19) took about two months after its previous release (0.960 in 2022-05-16). Hmm… IMHO it's likely to be soon, and we could wait for the next release! |
|
@moreal Mypy 0.981 which introduced general recursive types was released today. Let's upgrade Mypy to 0.981! |
f54ee8e to
ea25051
Compare
ea25051 to
92beac8
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
In Mypy development build (master branch), it became to support recursive types. (See python/mypy#731 (comment), python/mypy#13297).
This pull request makes the
bencodex-pythonpackage apply it with the development build.